Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix isRequired warnings in editors #37696

Merged
merged 3 commits into from Nov 5, 2020
Merged

Fix isRequired warnings in editors #37696

merged 3 commits into from Nov 5, 2020

Conversation

dmcavoy
Copy link
Contributor

@dmcavoy dmcavoy commented Nov 5, 2020 •
edited

After adding isRequired to a bunch of things in the editors Dave noticed the following warnings.

  1. The resources were required by the LessonEditor but were no longer being passed to the Lesson Editor because they are now stored in the resources redux instead
  2. Make expand not be required

davidsbailey
davidsbailey approved these changes Nov 5, 2020
View reviewed changes
Copy link
Member

@davidsbailey davidsbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for following up!

@davidsbailey
Copy link
Member

oh, I guess resources should also be removed here too then:

code-dot-org/apps/test/unit/lib/levelbuilder/lesson-editor/LessonEditorTest.js

Line 47 in 38eff3f

resources: []

@dmcavoy dmcavoy merged commit e47d59b into staging Nov 5, 2020
@dmcavoy dmcavoy deleted the is-required-follow-up branch November 5, 2020 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidsbailey davidsbailey davidsbailey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dmcavoy @davidsbailey