bump ml-playground #37706
Merged
bump ml-playground #37706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breville
reviewed
Nov 6, 2020
| @@ -2225,6 +2227,11 @@ | |||
| "@svgr/plugin-svgo" "^4.0.3" | |||
| loader-utils "^1.1.0" | |||
|
|
|||
| "@types/estree@*": | |||
There was a problem hiding this comment.
I'm trying to remember whether it was typical that we would end up introducing new dependencies in the main repo when bumping a version of our package, when we were doing ml-activities for Oceans. @madelynkasula or @bethanyaconnor do you remember?
There was a problem hiding this comment.
Oh, I found an example where we did introduce new dependencies, so I guess it's fine!
breville
approved these changes
Nov 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links
Testing story
Reviewer Checklist: