Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guarantee immersive-reader-sdk.renderButtons() only called once #37718

Merged
merged 1 commit into from Nov 6, 2020

Conversation

daynew
Copy link
Member

@daynew daynew commented Nov 6, 2020

Received a Zendesk ticket where the ImmersiveReaderButton keeps duplicating. This PR adds a flag to make sure the code which adds styling to the ImmersiveReaderButton only happens once.

Links

Testing story

Reviewer Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

Copy link
Contributor

@jmkulwik jmkulwik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have much context, but not seeing any issues :) LGTM

@daynew daynew merged commit 30ca392 into staging Nov 6, 2020
@daynew daynew deleted the zendesk-300542-fix-multiplying-imm-reader-button branch November 6, 2020 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants