Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate exported CB lessons and pass them to corresponding Lessons in Code Studio #37725

Merged
merged 13 commits into from Nov 8, 2020

Conversation

davidsbailey
Copy link
Member

@davidsbailey davidsbailey commented Nov 6, 2020

FInishes PLAT-498. Builds on the existing script for importing CB data as follows:

  • validates chapter data, and wraps any lessons owned directly by the unit in a single chapter
  • matches and validates CB lessons with code studio lessons by comparing relative position, lockable state, lesson name, and the stage name from code studio pull-through if present
  • calls new placeholder Level#update_from_curriculum_builder method for each code studio Level with corresponding CB data

Sample verbose output:
Screen Shot 2020-11-06 at 11 36 19 AM

Testing story

Lesson name warnings look mostly harmless:

Screen Shot 2020-11-06 at 11 39 51 AM

My unconfirmed suspicion as that mismatches are limited to express, pre-express and CSP because those courses do not actively use code studio pull-through, whereas Courses A-F and CSD do actively use it.

Future work

Aside from other work tracked in the same Jira epic, we may want to add another option to the command line script which allows running against a specific lesson or list of lessons, so that the script can be used to test out import one lesson at a time.

Reviewer Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

Copy link
Contributor

@bethanyaconnor bethanyaconnor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not super familiar with all these relationships still, but looks good to me. I say ship it!

@davidsbailey davidsbailey merged commit 4302eb7 into staging Nov 8, 2020
@davidsbailey davidsbailey deleted the validate-lessons branch November 8, 2020 22:59
end

def get_validated_chapters(cb_unit)
# In 2020, CSF and CSD lessons are all inside chapters, and CSP does not use
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Dave - I looks like CSP 2020 uses chapters on the LB side. https://levelbuilder-studio.code.org/s/csd1-2020

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Dani, that looks like a link to CSD, but your point is still valid -- CSP 2020 does use lesson groups on the LB side. I am using "chapter" to refer to data coming in from CB, and what I am trying to say here is that CSP 20 does not use Chapters on CB.

It would probably help if I clarified when I am talking about CB data without relying on the assumption that "chapter" means CB. I will update this in the next PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. I just wanted to check. (Sorry about the wrong link lol)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in 1c167d9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants