Construct valid regional partner for test #37788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Required for the Rails 5.2 upgrade. Similar to #37681, this is a product of the fact that the created regional partner was failing validation, which meant that it was failing to persist to the database, which means that the later steps of this test wasn't working. It's not entirely clear to me why the factory was failing to create a valid instance, but the simple fix is to just create one manually.
Hamms
added
the
Rails Upgrade
molly-moen
approved these changes
Nov 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for the Rails 5.2 upgrade.
Similar to #37681, this is a product of the fact that the created regional partner was failing validation, which meant that it was failing to persist to the database, which means that the later steps of this test wasn't working.
It's not entirely clear to me why the factory was failing to create a valid instance, but the simple fix is to just create one manually.
Reviewer Checklist: