Add new columns to teacher app export #37814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -25,6 +25,8 @@ def get_rows | |||
| if app.sanitize_form_data_hash[:principal_underrepresented_minority_percent] | |||
| urm_percent = app.sanitize_form_data_hash[:principal_underrepresented_minority_percent].to_f | |||
| end | |||
| accepted_statuses = %w(accepted_no_cost_registration accepted_notified_by_partner registration_sent paid accepted_not_notified) | |||
| accepted = accepted_statuses.include?(app.status) ? 1 : 0 | |||
There was a problem hiding this comment.
are we using numbers here so they can easily count the total number of acceptances?
There was a problem hiding this comment.
0/1 was the request from programs, they are currently semi-manually computing this column and putting 0/1 in, so I would guess it's for counting?
clareconstantine
approved these changes
Nov 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the following columns to the teacher app export:
accepted_no_cost_registration, accepted_notified_by_partner, registration_sent, paid, accepted_not_notified)Links
Testing story
Followed steps from this PR to verify export.
Reviewer Checklist: