micro:bit on Chromebooks #37815
Merged
micro:bit on Chromebooks #37815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
November 5, 2020 16:17
breville
reviewed
Nov 12, 2020
breville
reviewed
Nov 12, 2020
breville
reviewed
Nov 12, 2020
added 6 commits
November 12, 2020 16:00
…hromeserialport-microbit
breville
reviewed
Nov 25, 2020
| @@ -1,4 +1,7 @@ | |||
| /** @file Some misc. browser check methods for maker */ | |||
| /* global SerialPort */ // Maybe provided by the Code.org Browser | |||
There was a problem hiding this comment.
Oh I've never read it like that! We are sure that if we're in the Code.org (Maker) Browser, then we have the SerialPort. I believe the 'Maybe' applies to that we might be in the Code.org Browser or in the Chrome Browser with the Chrome App (Chromebook).
breville
approved these changes
Nov 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting micro:bit working on Chromebooks. Similar to the Circuit Playgrounds on Chromebook, we use chrome-serialport to communicate with the boards. chrome-serialport does not use promises like most of our code in this area, so there are some artifacts of working around that in the changes here.
Added JIRA tasks for: micro:bit celebration (non-blocking), getting micro:bit firmata/firmware version (non-blocking (and might not be worth investing in depending on our Chrome App deprecation plan) ), and getting micro:bit board version (non-block (also should depend on deprecation plan) ).
I have an adhoc for this branch to test on Chromebooks. LMK if you want me to turn it on to test.
Screenshot of MB setup in Maker App on Linux:
Screenshot of MB setup in Chrome on Chromebook:
Reviewer Checklist: