Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating HOC markdown files with locale-aware CB links #37833

Merged
merged 1 commit into from
Nov 12, 2020

Conversation

annaxuphoto
Copy link
Contributor

@annaxuphoto annaxuphoto commented Nov 12, 2020

Updating markdown files that include CB and locale-specific links to use the curriculum_url function, which generates URLs based on the user's current locale.

Before:
Screen Shot 2020-11-09 at 4 49 53 PM

After (language is Español (LATAM)):
Screen Shot 2020-11-09 at 4 51 49 PM

Links

Testing story

  1. Visit http://localhost.code.org:3000/oceans and select Español (LATAM) as the language
  2. Click on the "Ver recursos" button and verify that the CB link locale includes "es-mx"
  3. Verify the Lesson Plan links on http://localhost.code.org:3000/hourofcode/starwars http://localhost.code.org:3000/hourofcode/flappy http://localhost.code.org:3000/hourofcode/frozen http://localhost.code.org:3000/hourofcode/hourofcode http://localhost.code.org:3000/hourofcode/playlab all have locale-aware CB links

Reviewer Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

Copy link
Contributor

@Hamms Hamms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

@annaxuphoto
Copy link
Contributor Author

Thanks Elijah!

@annaxuphoto annaxuphoto reopened this Nov 12, 2020
@annaxuphoto annaxuphoto merged commit 3dd7569 into staging Nov 12, 2020
@annaxuphoto annaxuphoto deleted the markdown_cb_url_updates branch November 12, 2020 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants