New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DTL (Test > Levelbuilder): 0f055576 #37836

Merged

deploy-code-org merged 52 commits into levelbuilder from dtl_candidate_0f055576

Nov 12, 2020

Contributor

deploy-code-org commented Nov 12, 2020

No description provided.

davidsbailey and others added 30 commits

November 9, 2020 14:40


          improve comments around lockable lesson plans and CB chapters

1c167d9


          improve comments on get_validated_lesson_pairs

a193e3f


          improve dry run logging

ab98dc4


          move get_validated_cb_chapters call inside get_validated_lesson_pairs

93dbd10


          inline get_validated_cb_chapters

37e9e68


          inline cb_chapters variable and simplify cb_lessons assignment logic

a54c7f2


          extract get_cb_lessons

e9c9515


          add comment for get_cb_lessons

1d800fc


          compute lesson group pairs

5392fb3


          create placeholder method for updating a LessonGroup from cb data

2282d0b


          disable debug logging

655a798


          always print validated/updated summary for each unit

45516e8


          extract canonicalize helper

ed580da


          improve detection of similar lesson and lesson group names

db5d716


          improve canonicalize helper comments


          add chapter description to lesson group update method docs

acd6e78


          Add certificate for 2020 Minecraft Education Edition

42fc187


          Use ajax call for save and close

edd1f0b


          Remove name from components


          Use navigateToHref

f7f7d6a


          Add new tests to LessonEditor

95e1ce4


          Update lesson_controller_test

92aec34


          Merge branch 'staging' into save-close-ajax

cf07123


          Update CanCanCan to 2.2.0

b910cc0

Required for the Rails 5.2 upgrade; specifically, CanCanCommunity/cancancan#479 is required to fix an ActiveRecord query issue that we're seeing on controllers with autoloaded resources.

Reading through the changelog, it looks like the only major changes between this and our previous version are [several deprecations](https://github.com/CanCanCommunity/cancancan/blob/develop/CHANGELOG.md#200-may-18th-2017) for situations we aren't using.


          Setup: add details on ImageMagick with Pango

Add instructions on getting ImageMagick with Pango for macOS developers who want to personalize certificates locally.


          Use png instead of jpg for certificate image

47895e4


          Merge pull request #37806 from code-dot-org/staging

9ca4971

DTT (Staging > Test) [robo-dtt]


          Remove puts statement

675b448


          improve comments on get_lesson_group_pairs

fed634d


          Allow API call to be disabled via Gatekeeper and set TCP connect and …

02f9934

…HTTP read timeouts.

Hamms and others added 22 commits

November 11, 2020 17:48


          Merge pull request #37804 from code-dot-org/cancancan-2.3.0

763c060

Update CanCanCan to 2.2.0


          Merge pull request #37810 from code-dot-org/staging

90ac4ad

DTT (Staging > Test) [robo-dtt]


          Add parameter to say if should close after save

6833c49


          Remove rediret assertion from lessons test

e1d1c3a


          Merge pull request #37772 from code-dot-org/match-cb-chapters

66619c7

Match imported cb chapter data to corresponding lesson groups


          Merge pull request #37816 from code-dot-org/staging

d598cb5

DTT (Staging > Test) [robo-dtt]


          Merge pull request #37807 from code-dot-org/minecraft-education-editi…

a8caf4f

…on-2020-certificate

Minecraft education edition 2020 certificate


          Merge pull request #37773 from code-dot-org/avoid-rename-warnings

46cdbba

improve detection of similar lesson and lesson group names


          Merge pull request #37818 from code-dot-org/staging

e5b4eb2

DTT (Staging > Test) [robo-dtt]


          add banner to hoc overview page

b91f071


          Store timeout settings in DCDO.

95a90e3


          Merge pull request #37802 from code-dot-org/save-close-ajax

8c77a75

Lesson Edit Page: Don't navigate away on save unless save is successful


          Merge pull request #37820 from code-dot-org/staging

3fc4e1b

DTT (Staging > Test) [robo-dtt]


          staging content changes (-robo-commit)


          Merge pull request #37821 from code-dot-org/levelbuilder

1537b5a

DTS (Levelbuilder > Staging) [robo-dts]


          Merge pull request #37824 from code-dot-org/staging

1f0d6e3

DTT (Staging > Test) [robo-dtt]


          Merge pull request #37817 from code-dot-org/match-cb-chapters

e130ac5

improve comments on get_lesson_group_pairs


          Merge pull request #37828 from code-dot-org/staging

76a80a5

DTT (Staging > Test) [robo-dtt]


          Merge pull request #37809 from code-dot-org/protect-webpurify-with-ga…

8598a6c

…tekeeper

Protect against WebPurify outage


          Merge pull request #37830 from code-dot-org/staging

1a7d50d

DTT (Staging > Test) [robo-dtt]


          Merge pull request #37819 from code-dot-org/mini-codebytes

e2c810b

Add mini CodeBytes banner to HOC overview page


          Merge pull request #37831 from code-dot-org/staging

0f05557

DTT (Staging > Test) [robo-dtt]

deploy-code-org merged commit aa28735 into levelbuilder

deploy-code-org deleted the dtl_candidate_0f055576 branch

November 12, 2020 23:25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment