Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import show_calendar field from CB for code studio Script objects #37845

Merged
merged 2 commits into from Nov 21, 2020

Conversation

davidsbailey
Copy link
Member

@davidsbailey davidsbailey commented Nov 13, 2020

Depends on code-dot-org/curriculumbuilder#324. Finishes PLAT-245.

Testing story

Manually verified:

  1. No changes to coursea-2020 unit after being imported (show_calendar: false)
  2. show_calendar is true after importing csd3-2020:
[development] dashboard > u = Script.find_by_name('csd3-2020')
[development] dashboard > u.show_calendar
=> true

Reviewer Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@dmcavoy
Copy link
Contributor

dmcavoy commented Nov 13, 2020

If you save a script that has been updated with show_calendar it will clear the value if we don't add an input on the script edit page to keep it populated. This will get better with what I'm working on but figured its worth pointing out

@davidsbailey
Copy link
Member Author

If you save a script that has been updated with show_calendar it will clear the value if we don't add an input on the script edit page to keep it populated. This will get better with what I'm working on but figured its worth pointing out

Great catch Dani! To fix that, I think I'd need to either:

  1. update the script DSL logic to handle this, or
  2. wait until PLAT-460 is fixed, which seems like it should make the problem go away

I'll add a launch-blocking task to make sure this field is not getting wiped out on script save once PLAT-460 is done: https://codedotorg.atlassian.net/browse/PLAT-519

@dmcavoy
Copy link
Contributor

dmcavoy commented Nov 18, 2020

Does it need to go in the .script file though so that it would be seeded across environments or are we not worrying about that until we doing the seeding work? In any case I think its probably fine for it not to block this and to have PLAT 519 as a reminder that we need to follow up. I think adding the field on the Script Edit page is really a small work item so I'd be happy to take it after this ships

@davidsbailey davidsbailey merged commit abad1c1 into staging Nov 21, 2020
@davidsbailey davidsbailey deleted the import-unit-show-calendar branch November 21, 2020 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants