Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly cast session.id to a string everywhere we directly use it #37850

Merged
merged 1 commit into from
Nov 13, 2020
Merged

Explicitly cast session.id to a string everywhere we directly use it #37850

merged 1 commit into from
Nov 13, 2020

Conversation

Hamms
Copy link
Contributor

@Hamms Hamms commented Nov 13, 2020

Follow-up to #37756, which covered one relevant use case, but not all.

See that PR for more details

Testing story

This was originally caught by a UI test, so mostly relying on that. Also did some basic manual testing.

Reviewer Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@Hamms
Explicitly cast session.id to a string everywhere we directly use it
7cb9f46 
Follow-up to #37756, which covered one relevant use case, but not all.

See that PR for more details
@Hamms Hamms added the Rails Upgrade All work related to upgrading the version of Ruby on Rails we use. label Nov 13, 2020
@Hamms Hamms merged commit 55ddd0a into staging Nov 13, 2020
@Hamms Hamms deleted the cast-session.id-to-string-everywhere branch November 13, 2020 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjordan wjordan wjordan approved these changes

@clareconstantine clareconstantine clareconstantine approved these changes

Assignees
No one assigned
Labels
Rails Upgrade All work related to upgrading the version of Ruby on Rails we use.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Hamms @wjordan @clareconstantine