Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"updating footers across sites to include AWS, Github, and Google Clas…" #37939

Merged
merged 2 commits into from Nov 20, 2020

Conversation

annaxuphoto
Copy link
Contributor

@annaxuphoto annaxuphoto commented Nov 19, 2020

Reverts #37931

Same PR as #37889 with additional changes to the old site footer, which is used on https://code.org/curriculum/unplugged

This PR also increases the height of the dashboard footer so that there is no whitespace underneath the purple block.

Curriculum page (http://localhost.code.org:3000/curriculum/unplugged):
Screen Shot 2020-11-19 at 3 50 09 PM

Dashboard footer:
Screen Shot 2020-11-19 at 3 50 27 PM

@annaxuphoto annaxuphoto requested a review from a team as a code owner November 19, 2020 23:52
Copy link
Member

@breville breville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making those two small fixes!

@annaxuphoto annaxuphoto merged commit 89c61bf into staging Nov 20, 2020
@annaxuphoto annaxuphoto deleted the revert-37931-revert-37889-footer-copy branch November 20, 2020 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants