proactively silence a few deprecation warnings added in Rails 6.0 #38168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hamms
added
the
Rails Upgrade
wjordan
approved these changes
Dec 16, 2020
| @@ -8,9 +8,15 @@ | |||
|
|
|||
| # In addition to backtrace silencing, we also want to silence annoying deprecations: | |||
| silenced = [ | |||
| # Added in Rails 5.2 | |||
| /Single arity template handlers are deprecated/, | |||
| /Dangerous query method \(method whose arguments are used as raw SQL\) called with non-attribute argument\(s\)/, | |||
| /SourceAnnotationExtractor is deprecated! Use Rails::SourceAnnotationExtractor instead/, | |||
There was a problem hiding this comment.
Will these need to be worked on and removed from this silencer list before the upgrade is finished?
There was a problem hiding this comment.
yep! The way I'm thinking of the remaining upgrade work is basically two sets of checklist items; one is "the remaining test failures" and the other is this list of deprecations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing this in advance of the actual upgrade, just so it doesn't get forgot.
Reviewer Checklist: