Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one-and-a-half megabyte yaml file has been causing some issues when loading level fixtures, and looks to be set to cause even more issues on Rails 6.
Specifically, when trying to load fixtures as a part of
rake db:test:prepare
, we get the errorMysql2::Error: Commands out of sync; you can't run this command now
. It seems to be related to an issue with Mysql'smax_allowed_packet
configuration, We previously tried to bypass this by increasing the setting on the client (#38123) but it looks like to actually fix it we also need to increase the setting on the server, which is of course a bit more complicated.Instead, I'd simply like to do away with this enormous fixture. Looks like we have a total of three tests which are relying on it; two of which could simply be using FactoryBot instead to create the data they need, the third of which seems to just be testing that fixtures are getting loaded and so (unless I'm fundamentally misunderstanding the purpose of the test) is not testing anything that we actually care about.
Follow-up work
We've made a couple of attempts to adjust the
max_allowed_packet
value; once we've merged this, we can go through and undo those since this should render them unnecessary.Reviewer Checklist: