Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProgressTableStudentName #38216

Merged
merged 2 commits into from Jan 22, 2021
Merged

Conversation

cforkish
Copy link
Contributor

@cforkish cforkish commented Dec 11, 2020

this PR represents a combined effort between @cforkish and @maureensturgeon.

this is a refactored version of SectionProgressNameCell for use in the refactored progress tables. this component didn't warrant much cleanup, so there is very little change other than the name and file path.

you can refer to this tech spec to see how this component fits into the full table architecture.

Screen Shot 2021-01-22 at 10 46 10 AM

@cforkish cforkish force-pushed the cforkish/LP-1675-ProgressTableStudentName branch from 36b2f6a to 91beae9 Compare January 20, 2021 22:38
@cforkish cforkish changed the base branch from cforkish/LP-1674-ProgressTableLessonNumber to staging January 20, 2021 22:49
@cforkish cforkish marked this pull request as ready for review January 21, 2021 00:02
@cforkish cforkish requested a review from a team January 21, 2021 00:04
Copy link
Contributor

@jamescodeorg jamescodeorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. For similar PRs in the future, could you include a screenshot of the component? Thanks!

@cforkish cforkish merged commit 247b338 into staging Jan 22, 2021
@cforkish cforkish deleted the cforkish/LP-1675-ProgressTableStudentName branch January 22, 2021 18:50
@cforkish cforkish added the student progress PRs related to student progress label Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
student progress PRs related to student progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants