Add UI tests for users who sign up through /join/:section_code #38225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| And I type "#{password}" into "#user_password" | ||
| And I type "#{password}" into "#user_password_confirmation" | ||
| And I select the "#{age}" option in dropdown "user_age" | ||
| And I click selector ".btn.btn-primary" once I see it |
There was a problem hiding this comment.
@drew-beckmen I would suggest trying one of the steps with the "to load a new page" clause Otherwise, it can lead to problems if the next step runs before the navigation happens.
There was a problem hiding this comment.
Thank you @davidsbailey!
jmkulwik
approved these changes
Dec 14, 2020
jamescodeorg
approved these changes
Dec 15, 2020
This was referenced Jan 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes two UI tests to validate the behavior of the sign up form users hit at
/join/:section_codewhen they are not yet signed in/registered users. Our lack of test coverage in this area was highlighted by a bug I introduced last week (details in the Slack thread). These tests allow us to verify the sign up workflow for users who submit both valid and invalid inputs into the sign up form.Testing story
Ran UI tests locally.
Links
Reviewer Checklist: