Allow the import script to run on levelbuilder #38244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bethanyaconnor
changed the title
davidsbailey
approved these changes
Dec 16, 2020
bin/oneoff/import_unit_details.rb
Outdated
| @@ -83,6 +83,8 @@ def main(options) | |||
| script = Script.find_by_name!(unit_name) | |||
| log "found code studio script name #{script.name} with id #{script.id}" | |||
|
|
|||
| raise "Trying to import a script that is marked as stable" if script.is_stable | |||
There was a problem hiding this comment.
can we change this to check that the script is not hidden instead, here and below? all stable scripts should be visible, but checking for visible will protect scripts like dance party too.
lib/cdo/lesson_import_helper.rb
Outdated
| # In the future, only levelbuilder should be added to this list. | ||
| raise unless [:development, :adhoc].include? rack_env | ||
| raise unless [:development, :adhoc, :levelbuilder].include? rack_env | ||
| raise if lesson.script.is_stable |
There was a problem hiding this comment.
just noting that this means we won't be able to re-import the 20-21 scripts in development or adhoc after this, which is fine because we can/should be importing the 21-22 scripts now that they are available.
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves PLAT-573. Adds levelbuilder to the list of environments that can run the import script and presents the import script from being run on stable scripts.
Links
Testing story
Reviewer Checklist: