Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AiLab] Generic ML predict block v1.0 #38428

Closed
wants to merge 3 commits into from
Closed

Conversation

Erin007
Copy link
Contributor

@Erin007 Erin007 commented Jan 6, 2021

Hidden behind the ?enableExperiments=applab-ml experiment param this is the first iteration of a generic getPrediction block. The getPrediction block accepts a model name, testValues object and callback function as parameters.

Screen Shot 2021-01-07 at 3 22 36 PM

Further revisions will be based on the outcome of discussions based on this doc. In the meantime, the next step is to add in the code that will fetch the trained model, call to the ML libraries and return a prediction in mlApi.js.

@Erin007 Erin007 requested a review from breville January 6, 2021 20:24

export default function MLApi() {}

MLApi.getModelNames = function() {
Copy link
Contributor Author

@Erin007 Erin007 Jan 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is where things fall apart because the names aren't back from the call in time to show in the block dropdown -- dead end or am I missing a better way to do something similar?

Copy link
Contributor Author

@Erin007 Erin007 Jan 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen Shot 2021-01-06 at 3 26 57 PM

This is what I wanted it to do.

@Erin007 Erin007 changed the title [WIP] beginnings of a generic ml predict block [AiLab] Generic ML predict block v1.0 Jan 7, 2021
@Erin007 Erin007 marked this pull request as ready for review January 7, 2021 20:30
@Erin007
Copy link
Contributor Author

Erin007 commented Jan 21, 2021

This change got updated and rolled into #38664

@Erin007 Erin007 closed this Jan 21, 2021
@fisher-alice fisher-alice deleted the applab-model-load branch July 13, 2022 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant