Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not coerce bonus or assessment into booleans #38448

Merged
merged 4 commits into from
Jan 8, 2021

Conversation

davidsbailey
Copy link
Member

@davidsbailey davidsbailey commented Jan 7, 2021

See #38440 for context. allow nil values for bonus and assessment, so that we do not end up bouncing between nil and false for these values when the script and lesson edit pages are saved.

Testing story

Manually verified that saving the lesson edit page does not change these values back to false. Added test coverage which requires the code change in order to pass. The failing UI test in drone appears to be unrelated to this PR.

Reviewer Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@davidsbailey davidsbailey merged commit 6f229c5 into staging Jan 8, 2021
@davidsbailey davidsbailey deleted the bonus-assessment-null branch January 8, 2021 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants