do not coerce bonus or assessment into booleans #38448
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #38440 for context. allow
nil
values for bonus and assessment, so that we do not end up bouncing betweennil
andfalse
for these values when the script and lesson edit pages are saved.Testing story
Manually verified that saving the lesson edit page does not change these values back to
false
. Added test coverage which requires the code change in order to pass. The failing UI test in drone appears to be unrelated to this PR.Reviewer Checklist: