Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Profanity/Azure: Use CDO.shared_cache instead of Rails.cache #38453

Merged
merged 4 commits into from Jan 21, 2021
Merged

Profanity/Azure: Use CDO.shared_cache instead of Rails.cache #38453

merged 4 commits into from Jan 21, 2021

Conversation

maddiedierker
Copy link
Contributor

Updates ProfanityHelper and AzureTextToSpeech modules to use the CDO.shared_cache instead of Rails.cache to improve our cache hit rate. CDO.shared_cache uses ElastiCache and is shared across all instances, whereas Rails.cache is specific to each instance.

Links

Testing story

Updates unit tests.

Reviewer Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@maddiedierker maddiedierker requested a review from a team January 7, 2021 22:49
@maddiedierker maddiedierker merged commit 4b81399 into staging Jan 21, 2021
@maddiedierker maddiedierker deleted the refactor-cache branch January 21, 2021 00:55
@maddiedierker maddiedierker mentioned this pull request Jan 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajpal ajpal ajpal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maddiedierker @ajpal