Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dismiss language selector in regional_partner_mini_contact UI test #38467

Merged
merged 2 commits into from
Jan 8, 2021

Conversation

bethanyaconnor
Copy link
Contributor

This test has been failing on multiple drone runs. I could repro locally and this fixed the issue for me.

Links

Testing story

Reviewer Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@bencodeorg bencodeorg reopened this Jan 8, 2021
@bencodeorg bencodeorg self-requested a review January 8, 2021 18:10
@bencodeorg
Copy link
Contributor

Second commit just cleans up extra whitespace, and this fix unblocks failing builds, so merging!

@bencodeorg bencodeorg merged commit a24b140 into staging Jan 8, 2021
@bencodeorg bencodeorg deleted the mini-contact-ui-dismiss-language-selector branch January 8, 2021 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants