Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix behavior editing on LB #38471

Merged
merged 2 commits into from
Jan 8, 2021
Merged

Fix behavior editing on LB #38471

merged 2 commits into from
Jan 8, 2021

Conversation

ajpal
Copy link
Contributor

@ajpal ajpal commented Jan 8, 2021

Quick fix to the LB shared function edit page. This broke when we changed behaviors to use an id field instead of the behavior name. The page loads, but saving doesn't work
Error:
image

After:
image

Links

Testing story

Reviewer Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@ajpal ajpal requested a review from a team January 8, 2021 17:20
@ajpal ajpal merged commit 7c38440 into staging Jan 8, 2021
@ajpal ajpal deleted the jan8-lb-behavior-edit branch January 8, 2021 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants