Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show client time when script and lesson edit pages are saved #38472

Merged
merged 8 commits into from Jan 12, 2021

Conversation

davidsbailey
Copy link
Member

@davidsbailey davidsbailey commented Jan 8, 2021

Finishes PLAT-668.

before (levelbuilder):
Screen Shot 2021-01-08 at 8 40 24 AM

Screen Shot 2021-01-08 at 8 40 30 AM

before (localhost):
Screen Shot 2021-01-08 at 9 16 28 AM
Screen Shot 2021-01-08 at 9 16 34 AM

after (localhost):
Screen Shot 2021-01-08 at 9 22 27 AM
Screen Shot 2021-01-08 at 9 22 32 AM

Testing story

Manually verified that the last saved timestamp matches my local system clock time on the script edit page and lesson edit page.

Reviewer Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@davidsbailey
Copy link
Member Author

apologies, I sent this too soon. I will mention you both again when tests are passing.

@davidsbailey
Copy link
Member Author

@dmcavoy @bethanyaconnor this is ready for review now. Dani, thanks for the pointers to updatedAt. I just went and removed them in this PR.

@@ -139,11 +143,15 @@ describe('LessonEditor', () => {
expect(wrapper.find('.saveBar').find('FontAwesome').length).to.equal(1);
expect(lessonEditor.state().isSaving).to.equal(true);

clock = sinon.useFakeTimers(new Date('2020-12-01'));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! TIL :)

Copy link
Contributor

@dmcavoy dmcavoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up and cleaning up all those places where updatedAt was!

@davidsbailey davidsbailey merged commit 9e64972 into staging Jan 12, 2021
@davidsbailey davidsbailey deleted the fix-save-time branch January 12, 2021 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants