New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
show client time when script and lesson edit pages are saved #38472
Conversation
apologies, I sent this too soon. I will mention you both again when tests are passing. |
I added It should be removed from the following places: https://github.com/code-dot-org/code-dot-org/blob/staging/dashboard/app/models/script.rb#L1352 If you want me to follow up with that work let me know. |
@dmcavoy @bethanyaconnor this is ready for review now. Dani, thanks for the pointers to updatedAt. I just went and removed them in this PR. |
@@ -139,11 +143,15 @@ describe('LessonEditor', () => { | |||
expect(wrapper.find('.saveBar').find('FontAwesome').length).to.equal(1); | |||
expect(lessonEditor.state().isSaving).to.equal(true); | |||
|
|||
clock = sinon.useFakeTimers(new Date('2020-12-01')); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! TIL :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for following up and cleaning up all those places where updatedAt was!
Finishes PLAT-668.
before (levelbuilder):
before (localhost):
after (localhost):
Testing story
Manually verified that the last saved timestamp matches my local system clock time on the script edit page and lesson edit page.
Reviewer Checklist: