playSpeech cleanup: Rename languageCode to locale #38498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small rename for the structure of Azure TTS voices returned from the server. We were renaming Azure's "Locale" param to "languageCode," but "locale" is clearer.
Since we cache the list of voices from Azure (in Rails.cache, which is emptied/reset on every deploy), the client needs to support both keys ("languageCode" and "locale") to make sure we don't get a flurry of errors here. A day or so after this PR has deployed, I will merge #38499 to deploy the clean-up to totally remove "languageCode."
Links
Testing story
Updated unit tests.
Reviewer Checklist: