Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Make level ID required for level objects in React components" #38503

Merged
merged 1 commit into from Jan 11, 2021
Merged

Revert "Make level ID required for level objects in React components" #38503

merged 1 commit into from Jan 11, 2021

Conversation

jmkulwik
Copy link
Contributor

@jmkulwik jmkulwik commented Jan 11, 2021 •
edited

Reverts #38085

Full details: https://codedotorg.slack.com/archives/C0T0PNTM3/p1610395456498700

The header went missing on at least some levels in IE11.
The error appears to be related to header.build, but further investigation is needed.
image

@jmkulwik jmkulwik requested review from a team and cforkish January 11, 2021 20:39
@jmkulwik jmkulwik merged commit 2bc20cc into staging Jan 11, 2021
@jmkulwik jmkulwik deleted the revert-38085-level-id-required branch January 11, 2021 20:43
jmkulwik added a commit that referenced this pull request Jan 12, 2021
@jmkulwik
Revert "Merge pull request #38503 from code-dot-org/revert-38085-leve…
a11d48a 
…l-id-required"

This reverts commit 2bc20cc, reversing
changes made to b8e6a3b.
@cforkish cforkish added the student progress PRs related to student progress label Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cforkish cforkish Awaiting requested review from cforkish

Assignees
No one assigned
Labels
student progress PRs related to student progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jmkulwik @cforkish