Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show vocab on lesson overview #38510

Merged
merged 2 commits into from Jan 12, 2021
Merged

Conversation

bethanyaconnor
Copy link
Contributor

Adds a section for vocabulary on the lesson overview page.

To test this, I imported vocab using the script updates in #38486. I don't think it's a problem if this goes in before importing vocab from curriculumbuilder as the section will be hidden until any vocab is added.

Screen Shot 2021-01-11 at 4 10 53 PM

Links

Testing story

Reviewer Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

Copy link
Member

@davidsbailey davidsbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, Bethany!

@bethanyaconnor bethanyaconnor merged commit 1eeef2a into staging Jan 12, 2021
@bethanyaconnor bethanyaconnor deleted the vocab-on-lesson-overview branch January 12, 2021 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants