Updates to the Advocacy Page and PDFs #38523
Conversation
pegasus/sites.v3/code.org/public/advocacy/state-facts/AK.pdf.fetch
Outdated
Show resolved
Hide resolved
| @@ -13,6 +13,7 @@ state-facts: true | |||
| %script{src:'https://www.google.com/jsapi'} | |||
| %link{:rel=>'stylesheet', :type=>'text/css', :href=>'/css/state-facts-print.css'} | |||
| %link{:rel=>'stylesheet', :type=>'text/css', :href=>'/css/state-facts.css'} | |||
| %link{:rel=>'stylesheet', :href=>'https://maxcdn.bootstrapcdn.com/font-awesome/4.6.3/css/font-awesome.min.css'} | |||
There was a problem hiding this comment.
Pegasus should already have its own copy of this file...
There was a problem hiding this comment.
For some reason, without this line the font awesome icons disappear when we generated the PDF
There was a problem hiding this comment.
Yes, it probably makes sense to add font awesome, but I just think we should refer to our own served version, like we do here: https://github.com/code-dot-org/code-dot-org/blob/staging/pegasus/sites/code.org/views/theme.haml#L7
There was a problem hiding this comment.
ohhh that makes sense, thanks for pointing that out!
| @@ -479,7 +396,7 @@ state-facts: true | |||
| %div.policy-item | |||
| - if state_info[:state_plan_s] == 'Yes' | |||
| %div | |||
| <i class="far fa-check-square"></i> | |||
There was a problem hiding this comment.
No, the checked squares are showing the invalid icon symbol right now
pegasus/sites.v3/code.org/public/advocacy/state-facts/splat.haml
Outdated
Show resolved
Hide resolved
pegasus/sites.v3/code.org/public/advocacy/state-facts/splat.haml
Outdated
Show resolved
Hide resolved
| @@ -35,6 +35,9 @@ | |||
| %strong= format_integer_with_commas(jobs_nationwide) | |||
| Open computing jobs nationwide | |||
|
|
|||
| %strong=number_to_percentage(47, precision: 0) | |||
There was a problem hiding this comment.
Ah, do we plan to update this number somewhat regularly?
There was a problem hiding this comment.
We plan to have engineering update this number every Fall
…g/code-dot-org into jk-advocacy-page-pdfs-update
All of the changes are outlined in the spec
Here is an example updated state facts PDF to be compared to the old state facts PDF
New advocacy page for national stats:
Old advocacy page for national stats:
New advocacy page for state stats:
Old advocacy page for state stats:
Links
Testing story
Reviewer Checklist: