Bugfix: DebugConsole jumps to bottom on every componentDidUpdate #38587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maddiedierker
commented
Jan 15, 2021
maddiedierker
commented
Jan 16, 2021
Comment on lines
+217
to
+229
| componentDidUpdate(prevProps) { | ||
| const prevOutputSize = prevProps.logOutput.size; | ||
| if ( | ||
| typeof prevOutputSize === 'number' && | ||
| prevOutputSize !== this.props.logOutput.size | ||
| ) { | ||
| this.jumpToBottom(); | ||
| } | ||
| } | ||
|
|
||
| jumpToBottom = () => { | ||
| this._debugOutput.scrollTop = this._debugOutput.scrollHeight; | ||
| }; |
There was a problem hiding this comment.
note to reviewers: this is the functional change -- the rest of the changes in this file are clean-up
maddiedierker
changed the title
ajpal
approved these changes
Jan 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where clicking anywhere in the debug console output caused it to jump to the bottom of the output. Now, it will only jump to the bottom when something new is logged to the debug console.
Also some small clean-up because I couldn't resist. I'd recommend hiding whitespace changes when looking at the diff.
Links
Testing story
Reviewer Checklist: