Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make gamelab and spritelab animation libraries use the same category previews again #38608

Merged
merged 5 commits into from Jan 20, 2021

Conversation

JillianK
Copy link
Contributor

@JillianK JillianK commented Jan 15, 2021

In this PR I added logic and pngs so that gamelab and spritelab could use different category previews since we were updating the gamelab animation library with new categories. Now, we're updating the spritelab animation library with new categories so we need to take that logic out.

This also includes a change to change the display name for the "Game Blocks" category to "Video Games".

And the change in constants.rb is for the animation library manifest builder script

Links

Testing story

Reviewer Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@JillianK JillianK requested a review from a team as a code owner January 15, 2021 22:37
@JillianK JillianK requested a review from a team January 15, 2021 22:55
@JillianK JillianK changed the title [DO NOT MERGE] - Make gamelab and spritelab animation libraries use the same category previews again Make gamelab and spritelab animation libraries use the same category previews again Jan 20, 2021
Copy link
Contributor

@maddiedierker maddiedierker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 yay, we're getting closer to a new animation library!

@JillianK JillianK merged commit bad7103 into staging Jan 20, 2021
@JillianK JillianK deleted the no-custom-previews-spritelab branch January 20, 2021 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants