Fix placeholder text translation #38618
Conversation
hacodeorg
requested review from
daynew and
annaxuphoto
and removed request for
a team
hacodeorg
force-pushed
the
ha/fix-placeholder-translation
branch
from
f6cd115
to
0437899
Compare
| <block type="studio_ask"> | ||
| <title name="TEXT">#{original_str}</title> | ||
| </block> | ||
| <block type="studio_showTitleScreen"> | ||
| <title name="TITLE">#{original_str}</title> | ||
| <title name="TEXT">#{original_str}</title> | ||
| </block> | ||
| </xml> | ||
| </start_blocks> | ||
| </blocks> | ||
| </GamelabJr> | ||
| XML | ||
| localized_block_xml = level.localized_text_blocks(block_xml) | ||
| localized_block_xml = level.localized_blocks_with_placeholder_texts(block_xml) | ||
|
|
||
| # Expected result is an one-line XML, in which the original string | ||
| # has been replaced by a localized string. | ||
| block_xml_cleaned = block_xml.strip.gsub(/\s*\n\s*/, '') | ||
| expected_localized_block_xml = block_xml_cleaned.sub(original_str, localized_str) | ||
| expected_localized_block_xml = block_xml_cleaned.gsub(original_str, localized_str) | ||
|
|
||
| assert_equal expected_localized_block_xml, localized_block_xml |
There was a problem hiding this comment.
Does this test that there are 3 instances of original_str? I'm concerned it only detects that there is at least one instance of it.
There was a problem hiding this comment.
Correct, sub function replaces only 1 instance. But gsub will replace all the occurrences of the original_str by localized_str.
| # Localize placeholder texts in text blocks | ||
| def localized_text_blocks(blocks) | ||
| # Localizing placeholder texts in certain block types | ||
| def localized_blocks_with_placeholder_texts(blocks) |
There was a problem hiding this comment.
I'm wondering if we should add documentation of what a placeholder_text is and maybe a link to a an example block which uses it? We could also just put raw XML in the comments.
I know not many methods have any documentation at all, but it might be a good idea to save the knowledge you gained investigating this task.
I leave it up to you to decide if you think this is worth documenting and also where the right place for the documentation is.
There was a problem hiding this comment.
I have an example of a block with placeholder strings in a test. I can add a comment to let people know that test exists.
FND-1359
The original work at #36983 enabled translation for placeholder texts in Blockly blocks. However, it covers only 1 type of block which is
textblock. This PR adds support for 2 more types of block:studio_showTitleScreenandstudio_ask.Examples
Example 1: Translating 2 placeholder strings in a
studio_showTitleScreenblock from English to Vietnamese.Example 2: Translating placeholder strings in a
studio_askblock ("ask... to set...") and atextblock ("...") from English to Vietnamese.Testing story
bundle exec rails test test/models/blockly_test.rb.sync-in.rbto extract new placeholder strings toi18n/locales/source/course_content/folder.sync-down.rbby adding placeholder string translations to files ini18n/locales/<locale>/course_content/folder.sync-out.rbto distribute the changes fromi18n/locales/<locale>/course_content/*to/dashboard/config/locales/placeholder_texts.<locale>.json.