Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify warning when making changes to UI tests #38645

Merged
merged 4 commits into from
Jan 21, 2021
Merged

Clarify warning when making changes to UI tests #38645

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f6e0eba
Test warning message
bencodeorg Jan 20, 2021
d8becdd
Test warning message again
bencodeorg Jan 20, 2021
11981c9
Clearer warning when updating UI tests
bencodeorg Jan 20, 2021
efd60bd
Its 2021
bencodeorg Jan 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 7 additions & 1 deletion tools/hooks/scary_changes.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,13 @@ def detect_changed_feature_files

#{changes.join("\n")}

Please amend your commit message to include the tag [test all browsers] if you haven't already.
If you'd like Drone to test your changes across all browsers
(instead of only in Chrome, the default),
amend your commit message to include the tag [test all browsers] if you haven't already.

Note that (as of January 2021) Drone will not successfully run all tests across all browsers,
so you may need another commit without the [test all browsers] tag
if you'd like to see all tests (in Chrome) passing in Drone without manual inspection.
EOS
end

Expand Down