Adding lifecycle logging for i18n sync scripts #38655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hacodeorg
approved these changes
Jan 21, 2021
| `git checkout staging` if should_i "switch to staging branch" | ||
| rescue => e | ||
| puts "return_to_staging_branch failed from the error: #{e}" | ||
| raise e |
There was a problem hiding this comment.
Does this exception reported in Honeybadger?
There was a problem hiding this comment.
No it doesn't. I think I would prefer that it would ping @foundations-team in slack when the build failed, but I don't know how slack integration works at the moment. I just wanted to get something quick out. If you know how to, please setup a call with me!
daynew
added a commit
that referenced
this pull request
Jan 21, 2021
Revert "Merge pull request #38655 from code-dot-org/i18n-sync-logging"
daynew
added a commit
that referenced
this pull request
Jan 28, 2021
…-logging"" This reverts commit 4465089.
daynew
added a commit
that referenced
this pull request
Jan 28, 2021
Revert "Revert "Merge pull request #38655 from code-dot-org/i18n-sync…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding some extra logging for the i18n sync to make it clearer what the error was and when the different stages of the sync start/end.
rescueblock for logging any exceptions which are thrown and stop the scripts.Testing story