Navigate to script overview on save and close of lesson edit for lessons without lesson plan #38688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…script overview on close
dmcavoy
commented
Jan 23, 2021
dmcavoy
changed the title
davidsbailey
approved these changes
Jan 26, 2021
| ); | ||
| if (data.hasLessonPlan) { | ||
| navigateToHref( | ||
| `/lessons/${this.state.originalLessonData.id}${ |
There was a problem hiding this comment.
please pass the lesson path down from the server using the lesson_path helper. this will make it a lot easier to find and change the lesson paths later.
There was a problem hiding this comment.
I will create a follow up PR with this
bethanyaconnor
approved these changes
Jan 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you set has_lesson_plan to false on the lesson edit page and then hit "save and close" it will take you to the script overview page instead of the lesson plan page.
You also can't directly access a lesson plan for a lesson for which has_lesson_plan is false.
Links
Testing story
Reviewer Checklist: