[Spritelab] Enable Start in Animation Tab level configuration #38711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -359,6 +359,10 @@ P5Lab.prototype.init = function(config) { | |||
|
|
|||
| this.studioApp_.init(config); | |||
|
|
|||
| if (startInAnimationTab(getStore().getState())) { | |||
There was a problem hiding this comment.
i'm not sure i understand how moving this conditional from line 449 to line 362 fixed the issue we were seeing since this.studioApp_.init(config) is on line 360
There was a problem hiding this comment.
it's a little hard to follow because P5Lab.init() has a lot going on, but this.studioApp_.init(config) is inside another function (onMount), which is defined on line 324. So I'm moving the conditional to be after this.studioApp_.init(config) in that function, which is passed to P5LabView and called after that component is mounted
maddiedierker
approved these changes
Jan 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First change: Don't dispatch the
changeInterfaceModeevent until after we've calledStudioApp.init, which ensures that Blockly has been initialized properly. This fixes the following JS errors:Second change: Rerender Blockly.mainBlockSpace when switching from the costume tab to the code tab. This render only seems necessary the first time you switch from costume to code, but we don't know whether it's necessary from within the change handler, so I have it just always re-rendering. I don't think that'll hurt performance because it's just one render, and Blockly rerenders things basically any time you drag a block anyways.
Before:
initial page load:
switch to code:
Then if you resize the window or the instructions/playspace panes:
After:
initial page load:
switch to code:
initial page load:
switch to code:
Links
Testing story
Reviewer Checklist: