Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Flappy] Switch to Google Blockly #38732

Merged
merged 4 commits into from
Jan 26, 2021
Merged

[Flappy] Switch to Google Blockly #38732

merged 4 commits into from
Jan 26, 2021

Conversation

ajpal
Copy link
Contributor

@ajpal ajpal commented Jan 26, 2021 •
edited

The last attempt was reverted because of two tests (flappy.feature and flappydrag.feature) failing on iPhone, iPad, and Safari.

bd69705 and d815e6c are the new changes. Both just have to do with how drag events are simulated by our UI tests.

flappydrag.feature
image

flappy.feature
image

Links

Testing story

Reviewer Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@ajpal ajpal requested a review from a team January 26, 2021 17:54
@ajpal ajpal merged commit cd0d3c3 into staging Jan 26, 2021
@ajpal ajpal deleted the jan25-flappy branch January 26, 2021 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breville breville breville approved these changes

Assignees
No one assigned
Labels
google blockly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ajpal @breville