Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code.org logo alt text #38752

Merged
merged 2 commits into from Jan 29, 2021
Merged

Code.org logo alt text #38752

merged 2 commits into from Jan 29, 2021

Conversation

epeach
Copy link

@epeach epeach commented Jan 27, 2021

Part of Navigation accessibility work for Jan 2021 Hackathon. Before, Code.org logo read as "Visited Link" in my local screenreader. Now it reads as "Code.org Home Visited Link" to represent what the link does. Followed these instructions for logo link best practices: https://www.w3.org/WAI/tutorials/images/functional/

Reviewer Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@epeach epeach requested a review from a team as a code owner January 27, 2021 23:06
@Hamms
Copy link
Contributor

Hamms commented Jan 27, 2021

"translatable alt text" is a level of accessibility that I'm so pleased to see!

@epeach epeach merged commit 4ef9a58 into staging Jan 29, 2021
@epeach epeach deleted the code-logo-alt-text branch January 29, 2021 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants