Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LessonEditorDialog React Component #38789

Merged
merged 2 commits into from Jan 29, 2021
Merged

Conversation

Hamms
Copy link
Contributor

@Hamms Hamms commented Jan 28, 2021

We have a bunch of dialogs in the lesson editor that were all making identical customizations to the BaseDialog component. I extracted all that into a single LessonEditorDialog component, and updated the components to use it instead.

Also organized a few import statements.

Testing story

Updated a number of tests which apparently care about which specific component we're using to render dialogs. Also had a conversation with Dave about rethinking our approach to testing moving forward.

Reviewer Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

We have a bunch of dialogs in the lesson editor that were all making identical customizations to the BaseDialog component. I extracted all that into a single LessonEditorDialog component, and updated the components to use it instead.
@Hamms Hamms marked this pull request as ready for review January 29, 2021 19:51
@Hamms Hamms merged commit 5ddb59e into staging Jan 29, 2021
@Hamms Hamms deleted the clean-up-lesson-editor-dialogs branch January 29, 2021 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants