Add LessonEditorDialog React Component #38789
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a bunch of dialogs in the lesson editor that were all making identical customizations to the BaseDialog component. I extracted all that into a single LessonEditorDialog component, and updated the components to use it instead.
Also organized a few import statements.
Testing story
Updated a number of tests which apparently care about which specific component we're using to render dialogs. Also had a conversation with Dave about rethinking our approach to testing moving forward.
Reviewer Checklist: