Minor frontend fixes to improve unit test reliability #38797
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our testing of the feasibility of upgrading to react-16.13 a few unit tests failed due to the new version being stricter about catching errors. These fixes will prevent some tests from failing when we upgrade.
The fixes are:
.empty
in unit tests on lists (was calling on a non-existent state variable and on 0 before)Testing story
Tested these by running unit tests and verifying they still pass on our current react version, and will pass if we upgrade to > React 16.
Reviewer Checklist: