[Spritelab] UI Polish for pause button #38849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breville
reviewed
Feb 2, 2021
Comment on lines
+47
to
+51
| const buttonStyle = { | ||
| ...styles.button, | ||
| ...(this.props.isRunning && styles.runningColor), | ||
| ...(this.props.isPaused && styles.pausedColor) | ||
| }; |
|
Does the button get slightly wider when paused? Neat idea to use a circle to differentiate against the other buttons. It does seem we should unify on a design decision for play/pause across our system before releasing this widely. |
Wow, nice catch! It was a difference of ~1 pixel! Restructured things a bit and now it's always 42x42 |
breville
approved these changes
Feb 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No functional changes, just UI updates.
From the JIRA ticket:
greenblue circle (to differentiate it from the arrow buttons)Before
After
Links
Testing story
Reviewer Checklist: