Restore "use script id to find teacher feedback script level" #38860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidsbailey
force-pushed
the
revert-38855-revert-38729-use-feedback-script-id
branch
from
f9112da
to
56732d2
Compare
dmcavoy
approved these changes
Feb 12, 2021
Erin007
reviewed
Feb 12, 2021
| # will show up in script.script_levels. | ||
| script = create :script | ||
| lesson_group = create :lesson_group, script: script | ||
| lesson = create :lesson, lesson_group: lesson_group, script: script |
There was a problem hiding this comment.
No need to address as part of this PR, but I'm curious if there's anything we can do in factories to short cut knowing and creating each rung?
There was a problem hiding this comment.
yes - when creating a script level, the rung that is missing is lesson group. there should be a way to make the lesson factory create a lesson group, the same way the script level factory creates a lesson:
code-dot-org/dashboard/test/factories/factories.rb
Lines 725 to 727 in 62b10f0
I tried this, but it didn't work using similar syntax.
Erin007
approved these changes
Feb 12, 2021
davidsbailey
deleted the
revert-38855-revert-38729-use-feedback-script-id
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #38855, restoring #38729.
#38729 caused honeybadger errors when trying to view feedback on bubble choice sublevels. the problem is that the code in that PR assumed that the teacher feedback level would have its own script level. However, this is not true in the case of bubble choice levels, where only the bubble choice (parent) level itself has a script level.
The solution here is to first do the cheaper search for the level within the script. When that fails, do a more expensive search for the level within each bubble choice level in the script.