Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Spritelab] Disable input when paused or not running #38913

Merged
merged 1 commit into from
Feb 4, 2021
Merged

[Spritelab] Disable input when paused or not running #38913

merged 1 commit into from
Feb 4, 2021

Conversation

ajpal
Copy link
Contributor

@ajpal ajpal commented Feb 4, 2021

Small fix to disallow interacting with the input prompts when the program is not running or when it's paused
Before:
Feb-04-2021 12-15-06
Feb-04-2021 12-43-13

After:
Feb-04-2021 12-16-32
Feb-04-2021 12-47-04

Links

Testing story

Reviewer Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@ajpal ajpal requested a review from a team February 4, 2021 20:49
epeach
epeach approved these changes Feb 4, 2021
View reviewed changes
Copy link

@epeach epeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ajpal ajpal merged commit d455a05 into staging Feb 4, 2021
@ajpal ajpal deleted the feb4-disable-input-when-paused branch February 4, 2021 23:16
@ajpal ajpal mentioned this pull request Feb 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epeach epeach epeach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ajpal @epeach