Disable editing vocabulary word

[bethanyaconnor]

Follow up to this Slack discussion. We currently set the key of vocab equal to the word to 1. prevent duplicate definitions (for now) and 2. to make the vocab markdown syntax intuitive. This means that if a vocab word is edited, its key will be out of sync with these objectives.

The biggest downside to this solution is that if there's a typo in the word, it will be difficult to edit without creating a new object. I added a warning to that effect (open to suggestion on wording!) but this approach might need to be revisited if we hear feedback about this.

Updated add vocab dialog:

Updated edit dialog:

Links

• spec
• jira

Testing story

Reviewer Checklist:

• Tests provide adequate coverage
• Privacy and Security impacts have been assessed
• Code is well-commented
• New features are translatable or updates will not break translations
• Relevant documentation has been added or updated
• User impact is well-understood and desirable
• Pull Request is labeled appropriately
• Follow-up work items (including potential tech debt) are tracked and linked

[bethanyaconnor]

Also tagging @tess323 mostly for fyi but in case she has any objections!

[tess323]

Thanks for the heads up! Only feedback would be to make that alert red if its a low lift

[davidsbailey]

Looks great!

[dmcavoy]

@bethanyaconnor Does having word match the key prevent CSF from having two of the same words with different definitions for the common sense media lessons?

[bethanyaconnor]

Currently yes. I thought we were going to address that after April launch but I might've misunderstood something. Ideally I'd like a way to generate a key that makes sense for those vocabulary, i.e. debugging_cse or something.

FWIW I don't think it will be much work to implement this now if it's needed now.

[davidsbailey]

FWIW I don't think it will be much work to implement this now if it's needed now.

I'm open to this. What would this look like exactly in terms of changes that need to be made?

[bethanyaconnor]

Kind of depends how we want the UI to look. I've been envisioning a checkbox or something to mark a vocabulary as common sense media. Then modifying this function to take that into account. Then maybe disallowing editing for common sense media vocabulary (as that seems to be the requirement).

I didn't add properties to the vocabulary model because it wasn't needed originally but that would be an easy migration. But even with that, I think this would be less than a day of work.

[davidsbailey]

It could be worth considering if it helps us in the short term -- otherwise, if we're not quite sure how we want it to look yet, I would probably lean toward deferring it.

[bethanyaconnor]

I created a ticket in our backlog for that work so we can talk about it at planning. It isn't directly related to this PR though so I'm going to go ahead and merge this.