Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spritelab] Add level configuration to hide pause button and remove experiment #38944

Merged
merged 2 commits into from
Feb 12, 2021

Conversation

ajpal
Copy link
Contributor

@ajpal ajpal commented Feb 8, 2021

Checkbox on the level edit page that lets levelbuilders hide the pause button on a level if desired.
image
image

This PR also removes the experiment flag, so the pause button will be visible on all Sprite Lab levels unless hidePauseButton is set to true.

Links

Testing story

Reviewer Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@ajpal ajpal requested a review from a team February 8, 2021 17:41
@ajpal ajpal changed the title [Spritelab] Add level configuration to hide pause button [Spritelab] Add level configuration to hide pause button and remove experiment Feb 11, 2021
@maddiedierker
Copy link
Contributor

yay [for removing the experiment]! excited for the pause button to go live

@ajpal ajpal merged commit b511a73 into staging Feb 12, 2021
@ajpal ajpal deleted the feb8-pause-level-config branch February 12, 2021 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants