Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hbergam/signin callout UI #38953

Merged
merged 13 commits into from
Feb 11, 2021
Merged

Hbergam/signin callout UI #38953

merged 13 commits into from
Feb 11, 2021

Commits on Feb 8, 2021

  1. creating a smaller PR with only disconnected visual

    @hannahbergam
    hannahbergam committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    798240e View commit details
    Browse the repository at this point in the history

  2. Small component test

    @hannahbergam
    hannahbergam committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    d703a7a View commit details
    Browse the repository at this point in the history

  3. unit test fix

    @hannahbergam
    hannahbergam committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    6f7c793 View commit details
    Browse the repository at this point in the history

  4. added testing for cookie cases

    @hannahbergam
    hannahbergam committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    465006b View commit details
    Browse the repository at this point in the history

  5. troubleshooting unit tests

    @hannahbergam
    hannahbergam committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    32b1892 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2021

  1. got unit test running, still have test case failing

    @hannahbergam
    hannahbergam committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    a8f6130 View commit details
    Browse the repository at this point in the history

  2. added new test to check opacity, all tests passing

    @hannahbergam
    hannahbergam committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    41e3224 View commit details
    Browse the repository at this point in the history

  3. removing logic tests, adding language flexibility, WIP

    @hannahbergam
    hannahbergam committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    776689a View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2021

  1. refactored logic into its own js file, reworked unit tests

    @hannahbergam
    hannahbergam committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    de2f53a View commit details
    Browse the repository at this point in the history

  2. adding comments for clarity

    @hannahbergam
    hannahbergam committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    5e77dcd View commit details
    Browse the repository at this point in the history

  3. renamed showCallout for clarity, renamed file to wrapper, edited retu… 

    …rn from empty div to null
    @hannahbergam
    hannahbergam committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    113487d View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2021

  1. updated getContent to render, added header comment to wrapper file, a… 

    …nd made onclick required
    @hannahbergam
    hannahbergam committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    2a7eb99 View commit details
    Browse the repository at this point in the history

  2. adding clarifying comments

    @hannahbergam
    hannahbergam committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    3a25711 View commit details
    Browse the repository at this point in the history