Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update SETUP.md to refer to Ubuntu 18.04 #38975

Merged
merged 1 commit into from
Feb 10, 2021
Merged

update SETUP.md to refer to Ubuntu 18.04 #38975

merged 1 commit into from
Feb 10, 2021

Conversation

Hamms
Copy link
Contributor

@Hamms Hamms commented Feb 9, 2021

Since we're now using that rather than 16.04

Reviewer Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@Hamms Hamms requested a review from sureshc February 9, 2021 20:58
sureshc
sureshc approved these changes Feb 10, 2021
View reviewed changes
Copy link
Contributor

@sureshc sureshc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks for updating this.

@Hamms Hamms merged commit c161203 into staging Feb 10, 2021
@Hamms Hamms deleted the update-setup-ubuntu-version branch February 10, 2021 17:15
Hamms added a commit that referenced this pull request Feb 15, 2021
@Hamms
Fix broken link in SETUP.md
ebdc136 
broke in #38975
@Hamms Hamms mentioned this pull request Feb 15, 2021
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sureshc sureshc sureshc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Hamms @sureshc