Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java IDE: minor improvements #39000

Merged
merged 3 commits into from Feb 11, 2021
Merged

Java IDE: minor improvements #39000

merged 3 commits into from Feb 11, 2021

Conversation

molly-moen
Copy link
Contributor

A few style/accessibility improvements to the java ide:

  • add labels to the console and editor inputs
  • add a header to the console
  • fix gruntfile import for css file

Only visible change to the editor is the addition of the header to the console (and removal of the border that was previously around the console):
Screen Shot 2021-02-10 at 4 23 01 PM

Testing story

Tested locally. The Java IDE is only available for admins and levelbuilders currently.

Reviewer Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

Copy link
Contributor

@jmkulwik jmkulwik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One typo nit. Other than that, LGTM!

@molly-moen molly-moen merged commit 10c0417 into staging Feb 11, 2021
@molly-moen molly-moen deleted the java-ide-improvements branch February 11, 2021 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants