[Spritelab] Add color to reserved words #39014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -8,6 +8,7 @@ module.exports.SpritelabReservedWords = [ | |||
| 'CENTER', | |||
| 'World', | |||
| 'background', | |||
| 'color', | |||
There was a problem hiding this comment.
i'm not sure i understand how this list woks (mostly focused on this "p5 globals" section) -- are these all keywords that exist in p5[.play] that we want to take control of?
There was a problem hiding this comment.
these are built-in functions in p5.play that we want to not overwrite. This list is then passed into Blockly as reserved words, so that if a student makes a variable named color, it generates code like var color2 = ... instead of var color = ...
There was a problem hiding this comment.
ahhh, i had it backwards -- thank you!
maddiedierker
approved these changes
Feb 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick fix to prevent clobbering
colorwhich is a built-in p5.play functionBefore
After
Links
Testing story
Reviewer Checklist: