[Karel] Remove karel_2_10 integration test #39026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've had some problems with this test being flaky. Most recently, we increased the timeout (PR), however that hasn't entirely fixed the issue.
The level being tested is https://studio.code.org/s/20-hour/stage/13/puzzle/10
Each karel level has its own integration test verifying that the solution passes the level. This way of writing and testing levels is deprecated. Now, all levels are managed through Levelbuilder, and owned by Curriculum, not engineering. We will not be making any changes to this level (other than potentially moving it to Levelbuilder someday, at which point we would definitely delete this test). Additionally, we rarely make changes to Karel/Maze, so chances of regressions are quite small, and we still have level solution tests for most of the levels. So it feels safe enough to remove this test to reduce noise in our test pipeline.