Homepage: Display bhm link instead of video for en-US #39027
Conversation
| type: "celebrate_bhm", | ||
| } | ||
|
|
||
| actions.push(I18n.locale == :"en-US" ? bhm_action : code_video_action) |
There was a problem hiding this comment.
(very minor) Is locale a symbol or a string? (In most places, I see us just compare to en-US but don't know which is more correct. Either way, not too important.)
There was a problem hiding this comment.
Symbol, I tried as a string, it didn't work
There was a problem hiding this comment.
Also curious whether there's a standard of how we determine locale? I see elsewhere in that same file we look at request.locale, do you happen to know the difference?
There was a problem hiding this comment.
I do not - I'm assuming that the i18n locale is somehow set by the request locale?
|
One general question...did you get a chance to see how this looks on smaller screens? |
I've added screenshots of other sizes to the description |
| #homepage #actions .herolink-white i { | ||
| vertical-align: middle; | ||
| margin-right: 5px; | ||
| font-size: 26px; |
There was a problem hiding this comment.
Just curious, was 26px just the size that made things look right or was there a reason for picking this value?
There was a problem hiding this comment.
This is specifically for the icon style i, I just looked at the mocks in the ticket and it was the size that looked most like the icon in the mocks.
For en-US locale, display Celebrate Black History Month with us! link which links to
/blackhistorymonthon the homepage.This was tested locally (couldn't find homepage tests to add to).
Links
Testing story
Reviewer Checklist: