Get levels in last lesson of CSP 20-21 units (except unit 8) by absolute position

[dmcavoy]

For the 9 special case lessons in CSP 20-21 start looking up the scripts_levels using the lessons absolute position instead of relative_position. This results in if a user goes to /s/csp1-2020/stage/14/puzzle/1/page/1 for example they will get redirected to /s/csp1-2020/lockable/2/puzzle/1/page/1 but the /lockable url still remains the one we send users to through out the site.

This is part 1 of 5 for moving CSP 20-21 lockable lessons with lesson plans over to new URLs at /stage instead of /lockable. The steps are:

1. (THIS PR) Get script_level by absolute position instead of relative position for CSP 20-21 lockable lessons with lesson plans
2. (Send users to new CSP 20-21 URLs for lockable lessons with lesson plans and redirect old URL #39128) Start using /stage URLs for CSP 20-21 lockable lesson with lesson plans and redirect old /lockable URL to the new /stage URL.
3. (Update has_lesson_plan and relative_position for CSP 20-21 lockable lessons with lesson plans #39129) Set has_lesson_plan and update name on CSP 20-21 lockable lessons with lesson plans. This will update relative_position as well
4. (Create long term redirection routes for CSP 20-21 lockable lessons with lesson plans #39130) Add the permanent redirects to routes.rb for CSP 20-21 lockable lessons with lesson plans
5. (Remove transition code for CSP 20-21 lockable lessons with lesson plans #39131) Remove the controller code that creates the redirects for CSP 20-21 lockable lessons with lesson plans

Links

• spec
• jira

Testing story

• Manually tested going to different levels in different lessons in the CSP 20-21 units

[dmcavoy]

@davidsbailey can you take a look at this? I know I need to add the experiment flag here but wanted to check this is the right direction

[dmcavoy]

Reminder - Don't forget to check with Dayne on the translations for this

[dmcavoy]

Actually @davidsbailey do you think we can go without the experiment? You mentioned that in your initial comment.

[davidsbailey]

@dmcavoy if the steps without an experiment are:

1. make new urls start working using absolute_position, not relative_position
2. start sending users to new urls (e.g. users who click a link on script overview page)
3. redirect from old urls to new urls (e.g. users who have an old url bookmarked or stored in an LMS)
4. update relative_position in the DB
5. go back to routing via relative_position, not absolute_position

then it looks like this PR does steps 1 and 2. This seems risky to me, because if you had to revert this PR after it reached production, you'd end up with some CSP test takers pointing at the new URLs, which would then stop working when you reverted.

I think the safest bet will be to do step 1 first in isolation, which in this case would be just the changes to get_script_level, but not the changes in build_script_level_path. then test in production to make sure everything is working. that way, when you go to do steps 2 and 3 (either together or in isolation), if anything goes wrong you can simply revert them, and both old and new urls will keep working.

[dmcavoy]

@davidsbailey I think I have updated this PR to just do step 1. Let me know what you think and also what you think might be the best tests for this PR. You can also see the 4 follow up PRs now linked in the description if you want to look what follows this.

[davidsbailey]

ahh, I had not thought about the subpage urls. these urls will need to also work at their new locations before the step of "make new urls start working" can be considered to be complete. can you please add tests showing that those urls work? I think the way you've written the above unit tests looks good enough given what we're testing and how long we'll need them for.

[dmcavoy]

I'm not sure what you are looking for that is different from what is here. Can you clarify?

[davidsbailey]

please correct me if I am mistaken but it looks like you are testing what happens when you go to /s/csp2-2020/stage/15/puzzle/1/ . I am asking what happens at /s/csp2-2020/stage/15/puzzle/1/page/1 .

[dmcavoy]

Ah I see what you are saying. Going directly to that URL instead of the redirect. I'll add something

[davidsbailey]

Looks good, Dani!

My concern about multiple get requests within a single unit tests appears to be unfounded.

[bethanyaconnor]

Makes sense to me! What's special about unit 8?

[dmcavoy]

Unit 8 does not have a lockable lesson at the end (its the Create PT unit)

[dmcavoy]

Manual Testing Report

URL	Tested?
/s/csp1-2020/stage/14/puzzle/1	X
/s/csp1-2020/stage/14/puzzle/1/page/1	X
/s/csp1-2020/lockable/2/puzzle/1	X
/s/csp1-2020/lockable/2/puzzle/1/page/1	X
/s/csp4-2020/stage/15/puzzle/1	X
/s/csp4-2020/stage/15/puzzle/2	X
/s/csp4-2020/stage/15/puzzle/2/page/1	X
/s/csp4-2020/lockable/1/puzzle/1	X
/s/csp4-2020/lockable/1/puzzle/2	X
/s/csp4-2020/lockable/1/puzzle/2/page/1	X